Skip to content

Serialize Unity hinge reference with invariant culture #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sylvesterkaczmarek wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −1
Open

Serialize Unity hinge reference with invariant culture #3517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion unity/Runtime/Components/Joints/MjHingeJoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ protected override XmlElement OnGenerateMjcf(XmlDocument doc) {
throw new ArgumentException("Lower range value can't be bigger than Higher");
}
mjcf.SetAttribute("range", MjEngineTool.MakeLocaleInvariant($"{RangeLower} {RangeUpper}"));
mjcf.SetAttribute("ref", $"{Configuration}");
mjcf.SetAttribute("ref", MjEngineTool.MakeLocaleInvariant($"{Configuration}"));

return mjcf;
}
Expand Down
14 changes: 14 additions & 0 deletions unity/Tests/Editor/Components/Joints/MjHingeJointTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
using System;
using System.Collections;
using System.Collections.Generic;
using System.Globalization;
using System.Xml;
using NUnit.Framework;
using UnityEngine;
Expand Down Expand Up @@ -68,6 +69,19 @@ public void GenerateLimits() {
Assert.That(_doc.OuterXml, Does.Contain(@"range=""-20 10"""));
}

[Test]
public void GenerateReferenceUsesInvariantCulture() {
var previousCulture = CultureInfo.CurrentCulture;
CultureInfo.CurrentCulture = new CultureInfo("fr-FR");
try {
_joint.Configuration = 1.5f;
var element = _joint.GenerateMjcf("name", _doc);
Assert.That(element.GetAttribute("ref"), Is.EqualTo("1.5"));
} finally {
CultureInfo.CurrentCulture = previousCulture;
}
}

[Test]
public void ParsingPosition() {
var jointElement = (XmlElement)_doc.AppendChild(_doc.CreateElement("joint"));
Expand Down