Serialize Unity hinge reference with invariant culture - #3517
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Serialize Unity hinge reference with invariant culture#3517sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make Unity-generated hinge joint
refvalues locale-independent.MjHingeJoint.OnGenerateMjcfalready usesMjEngineTool.MakeLocaleInvariantforrange, but formatsrefwith the current process culture. On locales with a comma decimal separator, for examplefr-FR, a reference value such as 1.5 can therefore be written as1,5, which is not the intended MJCF numeric representation.This change:
refthroughMjEngineTool.MakeLocaleInvariantfr-FRand verifies the generated value remains1.5Validation
The branch is based directly on current
main, is one commit ahead, and changes onlyMjHingeJoint.csand its existing test file.The Unity EditMode suite was not executed in this environment, so no local Unity test pass is claimed.