Skip RFT approximation for points outside the grid - #14277
Merged
HakonSohoel merged 1 commit intoSep 3, 2026
Merged
Conversation
HakonSohoel
added
release-notes:bug-fix
HakonSohoel
enabled auto-merge (squash)
August 25, 2026 11:39
achaikou
reviewed
Aug 25, 2026
Observations whose location falls outside the grid have well_connection_cell and well_connection_cell_center None. Attempting to calculate an approximated response for a point with coordinates None would raise a TypeError. Since responses and observations are matched on well_connection_cell, an approximated response would not be matched to any observation. Approximation is therefore skipped for such points.
HakonSohoel
force-pushed
the
fix-error-when-point_to_approximate-is-outside-the-grid
branch
from
September 3, 2026 07:34
cdbec29 to
6c6533f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14277 +/- ##
=======================================
Coverage 91.75% 91.76%
=======================================
Files 485 485
Lines 34708 34701 -7
=======================================
- Hits 31848 31843 -5
+ Misses 2860 2858 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
10 tasks
achaikou
approved these changes
Sep 3, 2026
achaikou
left a comment
achaikou
left a comment
Contributor
There was a problem hiding this comment.
Nice! 🚀
And 😻 for that bug reporting :)
HakonSohoel
deleted the
fix-error-when-point_to_approximate-is-outside-the-grid
branch
September 3, 2026 08:44
|
Successfully created backport PR for |
ajaust
pushed a commit
that referenced
this pull request
Sep 7, 2026
Observations whose location falls outside the grid have well_connection_cell and well_connection_cell_center None. Attempting to calculate an approximated response for a point with coordinates None would raise a TypeError. Since responses and observations are matched on well_connection_cell, an approximated response would not be matched to any observation. Approximation is therefore skipped for such points. (cherry picked from commit 03e5ba6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observations whose location falls outside the grid have well_connection_cell and well_connection_cell_center None. Attempting to calculate an approximated response for a point with coordinates None would raise a TypeError. Since responses and observations are matched on well_connection_cell, an approximated response would not be matched to any observation. Approximation is therefore skipped for such points.
Issue
Resolves #14267
git rebase -i main --exec 'just rapid-tests')When applicable
merge screenshot-PR in ert-testdata before merging this PR.