[Backport version-25.0] Skip RFT approximation for points outside the grid - #14358
Open
scout-team-app[bot] wants to merge 1 commit into
Open
[Backport version-25.0] Skip RFT approximation for points outside the grid#14358scout-team-app[bot] wants to merge 1 commit into
scout-team-app[bot] wants to merge 1 commit into
Conversation
Observations whose location falls outside the grid have well_connection_cell and well_connection_cell_center None. Attempting to calculate an approximated response for a point with coordinates None would raise a TypeError. Since responses and observations are matched on well_connection_cell, an approximated response would not be matched to any observation. Approximation is therefore skipped for such points. (cherry picked from commit 03e5ba6)
scout-team-app
Bot
added
the
release-notes:bug-fix
10 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## version-25.0 #14358 +/- ##
=============================================
Coverage 91.90% 91.90%
=============================================
Files 482 482
Lines 33467 33468 +1
=============================================
+ Hits 30758 30760 +2
+ Misses 2709 2708 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #14277 to
version-25.0.