Add RFT QC widget status column test - #14355
Conversation
|
Created the test to see if the rft qc widget was affected by a polars bug (#14277 (comment)). It turned out it was not affected, but this test still verifies that the response status column is added as expected both with and without response approximation, so it is worth keeping. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #14355 +/- ##
===========================================
- Coverage 91.75% 70.55% -21.21%
===========================================
Files 485 497 +12
Lines 34708 36062 +1354
===========================================
- Hits 31848 25444 -6404
- Misses 2860 10618 +7758
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
|
||
| stored_observations = pl.DataFrame( | ||
| observations, | ||
| schema={ |
There was a problem hiding this comment.
Just a note:
To keep schemas consistent with possible future changes might be useful to use
defaults_generator's create_rft_observation + create_observation_dataframe's _handle_rft_observation (or just add new create_rft_observation_dataframe function to defaults_generator)
Also might be nice adding create_rft_response consistent with default rft observations (in the lines of create_seismic_response) to use standard response schema and get rid of explicitly defining uninteresting defaults like well-date-pressure.
Issue
Resolves #14330
git rebase -i main --exec 'just rapid-tests')When applicable
merge screenshot-PR in ert-testdata before merging this PR.