fix: DH-23199: Add overload function - #8448
Merged
mofojed merged 3 commits intoSep 2, 2026
Merged
Conversation
- Address comments from Copilot, prevent breakage from existing JsPlugins
Contributor
No docs changes detected for 6eb2f87 |
mofojed
added
NoDocumentationNeeded
NoReleaseNotesNeeded
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Duplicate Jackson creators can prevent manifest deserialization.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Preserves compatibility for existing JS plugins while supporting loader metadata.
Changes:
- Adds a legacy three-argument manifest factory.
- Provides an empty default loader implementation.
File summaries
| File | Description |
|---|---|
JsPluginManifestEntry.java |
Adds the compatibility overload. |
JsPlugin.java |
Makes loader optional by default. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
mofojed
changed the title
devinrsmith
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loaderdetails from package.json to the manifest.json (#8299) #8446 (review)