Skip to content

fix: DH-23199: Add overload function #8448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mofojed merged 3 commits into from
Sep 2, 2026
Merged

fix: DH-23199: Add overload function #8448

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7001f95
fix: DH-23199: Add default and overload function
mofojed Sep 2, 2026
deb2335
Potential fix for pull request finding
mofojed Sep 2, 2026
6eb2f87
Revert JsPlugin changes
mofojed Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions server/src/main/java/io/deephaven/server/plugin/js/JsPluginManifestEntry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ public static Builder builder() {
return ImmutableJsPluginManifestEntry.builder();
}

public static JsPluginManifestEntry of(
@JsonProperty(value = NAME, required = true) String name,
@JsonProperty(value = VERSION, required = true) String version,
@JsonProperty(value = MAIN, required = true) String main) {
return JsPluginManifestEntry.of(name, version, main, null);
}

@JsonCreator
public static JsPluginManifestEntry of(
@JsonProperty(value = NAME, required = true) String name,
Expand Down
Loading