Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion plugin/src/main/java/io/deephaven/plugin/js/JsPlugin.java
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,10 @@
*
* @return the loader configuration
*/
public abstract Optional<Object> loader();
@Default

Check warning on line 111 in plugin/src/main/java/io/deephaven/plugin/js/JsPlugin.java

View workflow job for this annotation

GitHub Actions / typedoc

(immutables:untype) @Value.Default on a container attribute make it lose its special treatment (when strictBuilder = true)

Check warning on line 111 in plugin/src/main/java/io/deephaven/plugin/js/JsPlugin.java

View workflow job for this annotation

GitHub Actions / publish

(immutables:untype) @Value.Default on a container attribute make it lose its special treatment (when strictBuilder = true)

Check warning on line 111 in plugin/src/main/java/io/deephaven/plugin/js/JsPlugin.java

View workflow job for this annotation

GitHub Actions / pydoc

(immutables:untype) @Value.Default on a container attribute make it lose its special treatment (when strictBuilder = true)

Check warning on line 111 in plugin/src/main/java/io/deephaven/plugin/js/JsPlugin.java

View workflow job for this annotation

GitHub Actions / javadoc

(immutables:untype) @Value.Default on a container attribute make it lose its special treatment (when strictBuilder = true)

Check warning on line 111 in plugin/src/main/java/io/deephaven/plugin/js/JsPlugin.java

View workflow job for this annotation

GitHub Actions / cppdoc

(immutables:untype) @Value.Default on a container attribute make it lose its special treatment (when strictBuilder = true)

Check warning on line 111 in plugin/src/main/java/io/deephaven/plugin/js/JsPlugin.java

View workflow job for this annotation

GitHub Actions / quick

(immutables:untype) @Value.Default on a container attribute make it lose its special treatment (when strictBuilder = true)

Check warning on line 111 in plugin/src/main/java/io/deephaven/plugin/js/JsPlugin.java

View workflow job for this annotation

GitHub Actions / checks

(immutables:untype) @Value.Default on a container attribute make it lose its special treatment (when strictBuilder = true)

Check warning on line 111 in plugin/src/main/java/io/deephaven/plugin/js/JsPlugin.java

View workflow job for this annotation

GitHub Actions / publish

(immutables:untype) @Value.Default on a container attribute make it lose its special treatment (when strictBuilder = true)
public Optional<Object> loader() {
return Optional.empty();
}

@Override
public final <T, V extends Plugin.Visitor<T>> T walk(V visitor) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ public static Builder builder() {
return ImmutableJsPluginManifestEntry.builder();
}

@JsonCreator
public static JsPluginManifestEntry of(
Comment thread
mofojed marked this conversation as resolved.
Outdated
@JsonProperty(value = NAME, required = true) String name,
@JsonProperty(value = VERSION, required = true) String version,
@JsonProperty(value = MAIN, required = true) String main) {
return JsPluginManifestEntry.of(name, version, main, null);
}

@JsonCreator
public static JsPluginManifestEntry of(
@JsonProperty(value = NAME, required = true) String name,
Expand Down
Loading