next/1478/20260904/v1 - #16185
Merged
Merged
Conversation
Some firewall rule analysis output had hardcoded paths. This commit is querying respective tables and uses the actual values. Ticket: 8951
A secondary action given without an explicit scope inherits the scope of the primary action, but was never validated against the scopes it supports itself. `pass` only supports packet and flow scope but the inheritance was never verified. Ticket: 8954
Previously, hook sequences in both rules and default policies allowed `pass` to be combined with incompatible hooks (e.g. reject or drop). This commit clamps pass to accept only. Ticket: 8954
Ticket: 8731 Adds a configurable limit to string lengths to avoid to retain too much memory for too long, and avoid producing log events that are too big
And log it with from_utf8_lossy Since we may now cut a too big failure_reason breaking a valid utf-8 string Ticket: 8731
The fallback memrchr() implementation initialized the search pointer to the one-past-end position and dereferenced it before decrementing, which is undefined behavior in C. Update the implementation to decrement the pointer before dereferencing while preserving memrchr() semantics. Compare bytes using unsigned char semantics to ensure values with the high bit set are handled correctly. Refactor the fallback into a local SCMemrchrFallback() helper so it can be exercised by unit tests on platforms that provide a native memrchr() implementation. Expand the unit test to cover first, middle, last, duplicate, single-byte, zero-length, absent-element, and high-byte values. Ticket: 9010 Signed-off-by: Urval Kheni <kheniurval777@gmail.com>
Ticket: 8147
victorjulien
requested review from
a team,
jasonish and
jufajardini
as code owners
September 5, 2026 01:27
|
WARNING:
Pipeline = 33801 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16185 +/- ##
==========================================
- Coverage 83.14% 83.14% -0.01%
==========================================
Files 1004 1004
Lines 277607 277682 +75
==========================================
+ Hits 230828 230874 +46
- Misses 46779 46808 +29
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=OISF/suricata-verify#3355