Rfb max length 8731 v3.7 - #16177
Closed
catenacyber wants to merge 2 commits into
Closed
Conversation
Ticket: 8731 Adds a configurable limit to string lengths to avoid to retain too much memory for too long, and avoid producing log events that are too big
And log it with from_utf8_lossy Since we may now cut a too big failure_reason breaking a valid utf-8 string Ticket: 8731
catenacyber
requested review from
a team,
jasonish and
jufajardini
as code owners
September 4, 2026 09:39
|
AI-generated review posted automatically by Suricata ai-review. Verdict: approve No high- or medium-severity findings. |
victorjulien
approved these changes
Sep 4, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16177 +/- ##
==========================================
- Coverage 83.14% 83.13% -0.02%
==========================================
Files 1004 1004
Lines 277579 277619 +40
==========================================
- Hits 230789 230786 -3
- Misses 46790 46833 +43
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 33789 |
Merged
Member
|
Merged in #16185, thanks! |
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/8731
Describe changes:
SV_BRANCH=OISF/suricata-verify#3352
#16164 with new SV PR + test