Backport8 8731 8799 8995 v1 - #16189
Closed
catenacyber wants to merge 4 commits into
Closed
Conversation
Ticket: 8731 Adds a configurable limit to string lengths to avoid to retain too much memory for too long, and avoid producing log events that are too big (cherry picked from commit f9515dc)
And log it with from_utf8_lossy Since we may now cut a too big failure_reason breaking a valid utf-8 string Ticket: 8731 (cherry picked from commit c608165)
Suricata never removed the unix command socket file after shutdown. The socket path (sockettarget) is now preserved in the struct UnixCommand_, because it is needed on shutdown to close the socket. The cleanup is done in the shutdown path of UnixManager(), which is reached uniformly whether shutdown is triggered by a fatal error or a signal (e.g. SIGTERM) via THV_KILL. This also applies for a clean shutdown via 'suricatasc -c shutdown'. Ticket: 8799 (cherry picked from commit 011f523)
A server can reject a BDAT command before the client sends the advertised chunk. Suricata would keep waiting for those bytes and treat the rest of the SMTP session as chunk data. Keeps subsequent SMTP commands and message data in sync with the server. Ticket: 8995 (cherry picked from commit 51ac400)
catenacyber
requested review from
a team,
jasonish,
jufajardini and
victorjulien
as code owners
September 5, 2026 14:48
|
AI-generated review posted automatically by Suricata ai-review. Verdict: request changes
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main-8.0.x #16189 +/- ##
==============================================
- Coverage 81.76% 78.14% -3.63%
==============================================
Files 1017 1017
Lines 277394 277270 -124
==============================================
- Hits 226815 216673 -10142
- Misses 50579 60597 +10018
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 33825 |
This was referenced Sep 5, 2026
Contributor
Author
|
Replaced by #16191 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/8732
https://redmine.openinfosecfoundation.org/issues/8802
https://redmine.openinfosecfoundation.org/issues/8996
Describe changes:
SV_BRANCH=OISF/suricata-verify#3356