feat: Simplify slasher settings - #16625
Merged
Merged
Conversation
spalladino
requested review from
LHerskind,
Maddiaa0 and
just-mitch
as code owners
August 28, 2025 01:26
spalladino
force-pushed
the
palla/gas-golf-slash-proposer
branch
from
August 28, 2025 14:05
b8732f3 to
562a4f6
Compare
spalladino
force-pushed
the
palla/slash-settings
branch
from
August 28, 2025 15:54
e5fd9c6 to
8008e3b
Compare
spalladino
force-pushed
the
palla/gas-golf-slash-proposer
branch
from
August 28, 2025 16:00
562a4f6 to
d4f6c55
Compare
spalladino
force-pushed
the
palla/slash-settings
branch
from
August 28, 2025 16:05
8008e3b to
9330fa3
Compare
LHerskind
reviewed
Aug 28, 2025
LHerskind
left a comment
LHerskind
left a comment
Contributor
There was a problem hiding this comment.
Just looked first few files. can look more tomorrow.
| require(QUORUM > ROUND_SIZE / 2, Errors.TallySlashingProposer__InvalidQuorumAndRoundSize(QUORUM, ROUND_SIZE)); | ||
| require(QUORUM <= ROUND_SIZE, Errors.TallySlashingProposer__InvalidQuorumAndRoundSize(QUORUM, ROUND_SIZE)); | ||
| require(SLASHING_UNIT > 0, Errors.TallySlashingProposer__SlashingUnitMustBeGreaterThanZero(SLASHING_UNIT)); | ||
| require(_slashAmounts[0] <= _slashAmounts[1], Errors.TallySlashingProposer__InvalidSlashAmounts(_slashAmounts)); |
Contributor
There was a problem hiding this comment.
Should there be some limit to avoid it being 0? Could they not all be 0 🤷
Contributor
Author
There was a problem hiding this comment.
I'm fine setting them all to zero if we want to have no effective slashing
| // Deployment stuff | ||
|
|
||
| /** How many seconds an L1 slot lasts. */ | ||
| ethereumSlotDuration: number; |
Contributor
There was a problem hiding this comment.
The amount of config is a crime against humanity.
Contributor
Author
There was a problem hiding this comment.
It is. I'm about to send another PR for validating config, so this does not blow up in our phases at deployment time, but earlier.
spalladino
force-pushed
the
palla/slash-settings
branch
from
August 29, 2025 12:38
9330fa3 to
cc519f7
Compare
just-mitch
approved these changes
Aug 29, 2025
spalladino
added a commit
that referenced
this pull request
Aug 29, 2025
Adds some missing features to slashing, and some cleanup: - Adds support for the slashValidatorNever and slashValidatorAlways config settings (now EthAddress lists) so that validators in those lists are never/always slashed. All validators in the local keystore are automatically added to the "never" list (unless `slashSelfAllowed` is set). - Checks if a slash payload is vetoed before trying to execute it, to avoid running an unnecessary simulation. This is handled on the slasher client directly. - Adds expiration for offenses and payloads to avoid cluttering the local stores. Removes unused `slashPayloadTtl` setting. - Moves `slasher/factory` methods around to avoid circular dependency. Builds on #16625
spalladino
force-pushed
the
palla/slash-settings
branch
from
August 29, 2025 17:01
0b75251 to
cc519f7
Compare
spalladino
enabled auto-merge
August 29, 2025 17:01
spalladino
added this pull request to the merge queue
Aug 29, 2025
spalladino
added a commit
that referenced
this pull request
Sep 1, 2025
Updates the slasher variables used in helm templates to match the new ones defined in #16694 and #16625. Sets all values to be empty, so we rely on the defaults set in the node and don't have multiple places where we define default values. Also adds a `check_env_vars` script (authored by claude) that checks if we are using any env var not defined in the env_var list in ts, so the CI should shout if we update a variable in ts-land but forget to update it in helm.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 1, 2025
Updates the slasher variables used in helm templates to match the new ones defined in #16694 and #16625. Sets all values to be empty, so we rely on the defaults set in the node and don't have multiple places where we define default values. Also adds a `check_env_vars` script (authored by claude) that checks if we are using any env var not defined in the env_var list in ts, so the CI should shout if we update a variable in ts-land but forget to update it in helm.
mralj
pushed a commit
that referenced
this pull request
Oct 13, 2025
Updates the slasher variables used in helm templates to match the new ones defined in #16694 and #16625. Sets all values to be empty, so we rely on the defaults set in the node and don't have multiple places where we define default values. Also adds a `check_env_vars` script (authored by claude) that checks if we are using any env var not defined in the env_var list in ts, so the CI should shout if we update a variable in ts-land but forget to update it in helm.
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16597
Builds on #16617