Repository navigation
fix: Update slash settings in helm templates - #16696
Merged
Merged
Conversation
Updates the slasher variables used in helm templates to match the new ones defined in #16694 and #16625. Sets all values to be empty, so we rely on the defaults set in the node and don't have multiple places where we define default values. Also adds a `check_env_vars` script (authored by claude) that checks if we are using any env var not defined in the env_var list in ts, so the CI should shout if we update a variable in ts-land but forget to update it in helm.
alexghr
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the slasher variables used in helm templates to match the new ones defined in #16694 and #16625. Sets all values to be empty, so we rely on the defaults set in the node and don't have multiple places where we define default values.
Also adds a
check_env_varsscript (authored by claude) that checks if we are using any env var not defined in the env_var list in ts, so the CI should shout if we update a variable in ts-land but forget to update it in helm.