feat: Slash lists, store expiration, veto checks - #16643
Merged
Merged
Conversation
spalladino
added
the
ci-no-fail-fast
spalladino
force-pushed
the
palla/slash-improvements
branch
from
August 28, 2025 21:41
78e40f4 to
976368e
Compare
spalladino
force-pushed
the
palla/slash-settings
branch
from
August 29, 2025 12:38
9330fa3 to
cc519f7
Compare
spalladino
requested review from
LHerskind,
Maddiaa0 and
just-mitch
as code owners
August 29, 2025 12:38
spalladino
force-pushed
the
palla/slash-improvements
branch
from
August 29, 2025 15:01
976368e to
61c592a
Compare
Adds some missing features to slashing: - Adds support for the slashValidatorNever and slashValidatorAlways config settings (now EthAddress lists) so that validators in those lists are never/always slashed. All validators in the local keystore are automatically added to the "never" list. - Checks if a slash payload is vetoed before trying to execute it, to avoid running an unnecessary simulation. This is handled on the slasher client directly. - Adds expiration for offenses and payloads to avoid cluttering the local stores. Removes unused slashPayloadTtl setting. - Avoids posting committee addresses during executeRound for committees that are not slashed, in order to save calldata gas.
spalladino
force-pushed
the
palla/slash-improvements
branch
from
August 29, 2025 15:02
61c592a to
c5fa2d3
Compare
just-mitch
approved these changes
Aug 29, 2025
Contributor
Author
|
Accidentally merged against the other open feature branch. Will reopen against |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 29, 2025
Adds some missing features to slashing: - Adds support for the slashValidatorNever and slashValidatorAlways config settings (now EthAddress lists) so that validators in those lists are never/always slashed. All validators in the local keystore are automatically added to the "never" list, unless a `slashSelfAllowed` is set. - Checks if a slash payload is vetoed before trying to execute it, to avoid running an unnecessary simulation. This is handled on the slasher client directly. - Adds expiration for offenses and payloads to avoid cluttering the local stores. Removes unused `slashPayloadTtl setting`. - Avoids posting committee addresses during executeRound for committees that are not slashed, in order to save calldata gas. - Moves slasher factory methods around to avoid circular dependency. Previously posted as #16643 but was accidentally merged against the wrong branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some missing features to slashing, and some cleanup:
Adds support for the slashValidatorNever and slashValidatorAlways config settings (now EthAddress lists) so that validators in those lists are never/always slashed. All validators in the local keystore are automatically added to the "never" list (unless
slashSelfAllowedis set).Checks if a slash payload is vetoed before trying to execute it, to avoid running an unnecessary simulation. This is handled on the slasher client directly.
Adds expiration for offenses and payloads to avoid cluttering the local stores. Removes unused
slashPayloadTtlsetting.Moves
slasher/factorymethods around to avoid circular dependency.Builds on #16625