Repository navigation
feat: update mapper to avoid failure when ROIs are not passed - #504
Merged
Merged
Conversation
dougollerenshaw
changed the title
carriestine
approved these changes
Oct 22, 2026
arielleleon
reviewed
Oct 22, 2026
arielleleon
requested changes
Oct 22, 2026
arielleleon
left a comment
arielleleon
left a comment
Collaborator
There was a problem hiding this comment.
Just one small thing
arielleleon
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #498
Previously, the presence/absence of ROI configs gated whether or not PatchCordConfigs were defined. However, the details of the PatchCordConfig were derived solely from the implanted fibers in the procedures. After this PR, PatchCordConfigs will be defined regardless, using only implanted fibers (identifed from procedures metadata). This will allow the ROI configs to be nullable.
Note that, in the future, we should be defining patch cord configs solely on the actual connection pattern used at the rig. That is dependent on FIP scheduler being in use and will assume that the schedule is always updated if RAs are unable to match the originally scheduled connection pattern (e.g. if a fiber is broken or otherwise cannot be connected as originally scheduled).
Also note that this will be backward compatible with existing FIP data, allowing this mapper update to be deployed before AllenNeuralDynamics/aind-metadata-extractor#54