Repository navigation
Update acquisition_type logic - #489
Merged
Merged
Conversation
Member
|
I'm going to hold on approving this until we can bump the minimum required aind-data-schema version to match the new merge logic. |
Contributor
Author
|
@dbirman are we ready to revisit this PR? |
Member
|
Sent a message but also putting a comment here for visibility, aind-data-schema v2.9.1 is ready to support this. I'll open a PR. |
dbirman
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #414
Takes
acquisition_typeif passed, otherwise sets to empty string.Requires a downstream schema change to ignore the empty string when combining two acquisition files (e.g. acquisition_type:"A" + acquisition_type:"" = acquisition_type:"A")