Repository navigation
fix: restore the chat window after it is minimized - #180
iis-MarkKuang wants to merge 1 commit into
Conversation
Minimizing the panel left it miniaturized without its own Dock tile, and the Chat menu then hid it instead of showing it again. Co-authored-by: Cursor <cursoragent@cursor.com>
fabianleonaressi95
left a comment
There was a problem hiding this comment.
I reviewed the implementation and the two added tests. The state handling is coherent: a minimized dialog is no longer treated as an ordinary visible/open dialog, showNormal() clears the minimized state, and the anchoring logic avoids moving the minimized window.
One validation item remains: the PR's manual test-plan checkbox is still unchecked. Because the reported failure is specifically macOS 15.5/AppKit behavior (including the absence of a separate Dock tile for this parented dialog), the offscreen Qt tests cannot fully establish the platform-level behavior. Please run and record the exact issue reproduction on macOS: open Chat → minimize via the window control → reopen from the cat menu → repeat once → close/hide. I would also retain the repeated-cycle check as a regression scenario.
I found no code-level blocker in the diff, but I would not treat the macOS-specific reproduction as verified until that manual check is recorded.
|
Recorded the manual check on this Mac (macOS 15.8.2, mycat 0.1.38 from this branch). Sequence: open Chat from the cat's menu, minimize with the yellow window button, open Chat again, repeat that once, then close with the red button. The cat stayed visible the whole time. After each minimize the chat window left the screen. It does not get its own Dock icon, because the dialog belongs to the cat window. Choosing Chat brought it back both times, at the same place and size: 919,258, 360×448, delta 0. Close hid it again. |
|
Follow-up verification from my side: the macOS reproduction is now recorded in the PR discussion (two minimize/restore cycles, unchanged position and 360×448 size, close/hide works). The implementation and the two focused regression tests look coherent. The remaining validation gap is CI on the PR head commit |

Review the chat-window restore. Fixes #181.
Minimizing the chat panel left it small, with no Dock icon of its own, because the dialog belongs to the cat window. The Chat menu treated that minimized window as already open and hid it. The next
show()did not clear the minimized state, so the panel stayed closed.Chat now restores the panel with
showNormal(). A minimized panel stays where it was. It is not moved back beside the cat.Checked:
ruff check .QT_QPA_PLATFORM=offscreen python -m pytest -q --timeout=60 --timeout-method=threadon Python 3.12: 496 passed, 11 skipped.--forkedsegfaults in this macOS Qt setup when the offscreenQApplicationis created in the child, so that run is left to CI on Ubuntu.Next: watch that recording on #181.