-
Notifications
You must be signed in to change notification settings - Fork 318
Make Grid Lanes canonical and Masonry redirect #4225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| kind: moved | ||
| redirect_target: masonry | ||
| redirect_target: grid-lanes |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # Generated from: display-grid-lanes.yml | ||
| # This file intentionally left blank. | ||
| # Do not edit this file. | ||
| # The data for this feature has moved to masonry.yml | ||
| # The data for this feature has moved to grid-lanes.yml | ||
|
|
||
| {} |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,2 +1,13 @@ | ||||||
| kind: moved | ||||||
| redirect_target: masonry | ||||||
| name: Grid lanes | ||||||
| description: "The `display: grid-lanes` or `display: inline-grid-lanes` CSS declaration creates a layout where items are tightly packed layout in parallel lanes. Items are placed one by one in the lane that has the most available space. Also known as masonry." | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. copy editing nits
Suggested change
|
||||||
| spec: https://drafts.csswg.org/css-grid-3/ | ||||||
| group: layout | ||||||
| caniuse: css-grid-lanes | ||||||
| compat_features: | ||||||
| - css.properties.display.grid-lanes | ||||||
| - css.properties.display.inline-grid-lanes | ||||||
| - css.properties.flow-tolerance | ||||||
| - css.properties.flow-tolerance.infinite | ||||||
| - css.properties.flow-tolerance.normal | ||||||
| - css.properties.grid-template-columns.masonry | ||||||
| - css.properties.grid-template-rows.masonry | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've opened a BCD PR to remove these two keys mdn/browser-compat-data#30183
Suggested change
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The change has landed in BCD, so this suggestion ought to be applied and the dist files regenerated. |
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,14 @@ | ||
| # Generated from: grid-lanes.yml | ||
| # This file intentionally left blank. | ||
| # Do not edit this file. | ||
| # The data for this feature has moved to masonry.yml | ||
| # Do not edit this file by hand. Edit the source file instead! | ||
|
|
||
| {} | ||
| status: | ||
| baseline: false | ||
| support: {} | ||
| compat_features: | ||
| - css.properties.display.grid-lanes | ||
| - css.properties.display.inline-grid-lanes | ||
| - css.properties.flow-tolerance | ||
| - css.properties.flow-tolerance.infinite | ||
| - css.properties.flow-tolerance.normal | ||
| - css.properties.grid-template-columns.masonry | ||
| - css.properties.grid-template-rows.masonry |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,2 @@ | ||
| name: Masonry | ||
| description: "The `display: grid-lanes` or `display: inline-grid-lanes` CSS declaration creates a layout where items are tightly packed, like brickwork, in parallel lanes. Items are placed one by one in the lane that has the most available space." | ||
| spec: https://drafts.csswg.org/css-grid-3/ | ||
| group: layout | ||
| caniuse: css-grid-lanes | ||
| kind: moved | ||
| redirect_target: grid-lanes |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,6 @@ | ||
| # Generated from: masonry.yml | ||
| # Do not edit this file by hand. Edit the source file instead! | ||
| # This file intentionally left blank. | ||
| # Do not edit this file. | ||
| # The data for this feature has moved to grid-lanes.yml | ||
|
|
||
| status: | ||
| baseline: false | ||
| support: {} | ||
| compat_features: | ||
| - css.properties.grid-template-columns.masonry | ||
| - css.properties.grid-template-rows.masonry | ||
| {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
features/draft/specfolder files are generated and don't need to be updated by hand. If you drop the changes to those files from your PR, you'll eliminate some conflicts and guarantee that there will be no future conflicts with those files.