Make Grid Lanes canonical and Masonry redirect - #4225
Conversation
github-actions
Bot
added
the
feature definition
I took the wrong merge direction here.
|
This relates to issue #4101 |
|
This was discussed at yesterday's WebDX CG call (notes). |
|
@jdatapple is there a PR to update MDN's masonry guide? https://developer.mozilla.org/en-US/docs/Web/CSS/Guides/Grid_layout/Masonry_layout |
| - css.properties.grid-template-columns.masonry | ||
| - css.properties.grid-template-rows.masonry |
There was a problem hiding this comment.
I've opened a BCD PR to remove these two keys mdn/browser-compat-data#30183
| - css.properties.grid-template-columns.masonry | |
| - css.properties.grid-template-rows.masonry |
There was a problem hiding this comment.
The change has landed in BCD, so this suggestion ought to be applied and the dist files regenerated.
|
|
Back on August 6, we discussed this PR in the WebDX meeting. I mentioned that web-features's current editorial policy is to favor descriptiveness or prescriptiveness, so I objected to this PR on the grounds that we'd be getting ahead of (for example) MDN's documentation on the subject. At the time, MDN still used the masonry terminology. Since then, mdn/content#45049 has landed scrubbing the word "masonry" from MDN (I don't love the memory holing there and don't think we should follow their lead on that, but that's what happened). I'll give this a new review. |
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
Some little changes required here, but it's not far off from completion.
There was a problem hiding this comment.
The features/draft/spec folder files are generated and don't need to be updated by hand. If you drop the changes to those files from your PR, you'll eliminate some conflicts and guarantee that there will be no future conflicts with those files.
| kind: moved | ||
| redirect_target: masonry | ||
| name: Grid lanes | ||
| description: "The `display: grid-lanes` or `display: inline-grid-lanes` CSS declaration creates a layout where items are tightly packed layout in parallel lanes. Items are placed one by one in the lane that has the most available space. Also known as masonry." |
There was a problem hiding this comment.
copy editing nits
| description: "The `display: grid-lanes` or `display: inline-grid-lanes` CSS declaration creates a layout where items are tightly packed layout in parallel lanes. Items are placed one by one in the lane that has the most available space. Also known as masonry." | |
| description: "The `display: grid-lanes` and `display: inline-grid-lanes` CSS declarations create a layout where items are tightly packed in parallel lanes. Items are placed one by one in the lane that has the most available space. Also known as masonry." |
| - css.properties.grid-template-columns.masonry | ||
| - css.properties.grid-template-rows.masonry |
There was a problem hiding this comment.
The change has landed in BCD, so this suggestion ought to be applied and the dist files regenerated.
- Updated description - Removed no longer valid properties
I sent mdn/content#45319 to bring back the term "masonry", as an "also known as" kind of mention, to improve findability and ease of understanding. |
|
@jdatapple to be able to merge this, it looks like the PR still needs to drop the changes from |
4 participants
CSS Grid Lanes shipped in Safari 26.4, it exists in MDN BCD, and reference pages on MDN Web Docs have been submitted. (see Add CSS Grid Lanes reference pages).
Keeping Masonry canonical for searchability isn't necessary. If Masonry becomes the alias, it still shows up in search and still guides developers. It just redirects them to Grid Lanes, the name of the thing they can actually use today. Aliases point in both directions for discovery so they don't have to be the canonical entry to be findable. Searchability doesn't justify keeping Masonry as the canonical ID.
So, here's a PR to flip the relationship.
As my first contribution to this repo, let me know what I need to correct so I can get better at it in the future.