-
Notifications
You must be signed in to change notification settings - Fork 158
Update a no href to map to link role #2863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lolaodelola
wants to merge
9
commits into
w3c:main
Choose a base branch
from
lolaslab:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9c323bc
Update a no href to map to link role
lolaodelola decf99a
Merge branch 'main' into main
lolaodelola d523b9b
Add .idea to gitig
lolaodelola 010bba9
Add row for a with click listener
lolaodelola 5e7a033
Merge branch 'main' into main
lolaodelola 184cbb5
Expand a with no href to include no click listener.
lolaodelola 41bdd36
update comment for a with click event
lolaodelola 3914352
add missing full stop
lolaodelola 88e4a34
Merge branch 'main' into main
lolaodelola File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -220,3 +220,6 @@ pip-log.txt | |
|
|
||
| # Local Netlify folder | ||
| .netlify | ||
|
|
||
| # Jet Brains | ||
| .idea/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: Calling it out as this seems auxiliary like something JetBrains added. Might be good to separate if we feel like this is a helpful addition to '.gitignore', but that might be personal preference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I manually added this following the existing pattern. You think this should be taken out and put in a different PR?