Update a no href to map to link role - #2863
Conversation
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Jet Brains app stuff
|
NIT feedback otherwise LGTM. I also looked into Area tags and found that they were treated similarly in Firefox but not in chrome/safari it didn't look like. |
|
Thanks @HaTheo! I think we may need more discussion on the area tags. |
|
@HaTheo can you leave a review? you only left a comment :) |
| <section> | ||
| <h4>Substantive changes since moving to the <a href="https://www.w3.org/WAI/ARIA/">Accessible Rich Internet Applications Working Group</a> (03-Nov-2019)</h4> | ||
| <ul> | ||
| <li>12-Aug-2026: Add `a with click listener` to have `link` role in keeping with browser implementations. See <a href="https://github.com/w3c/html-aam/issues/608">GitHub Issue 608</a> </li> |
There was a problem hiding this comment.
NIT: missing period/. before </li> for consistency.
|
|
||
| # Jet Brains |
There was a problem hiding this comment.
NIT: Calling it out as this seems auxiliary like something JetBrains added. Might be good to separate if we feel like this is a helpful addition to '.gitignore', but that might be personal preference.
There was a problem hiding this comment.
I manually added this following the existing pattern. You think this should be taken out and put in a different PR?
| </td> | ||
| </tr> | ||
| <tr> | ||
| <th>Comments</th> |
There was a problem hiding this comment.
Might be good to specify that this applies only to direct onClick and click event listeners in the comments for clarity. Especially as delegated event listeners become more common and James' callout.
There was a problem hiding this comment.
NIT: Should explicitly say without click listener for clarity.
There was a problem hiding this comment.
You mean like no href and no click listener?
There was a problem hiding this comment.
Yes, since it's broken out into three options: a (represented as a hyperlink); a (without href); and a (with a click listener) there's a bit of overlap between an a without an href and an a with a click listener. I just thought specifying it would clear up any ambiguity. I was thinking this could say "a (without href or click listener)"
3 participants
Closes html-aam/608
Describe Change Here!
And a few other todo items (delete this section after performing them):
spec:<spec_name>label. If you don't have privileges to do this, editors will do it for you.Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.