Skip to content

p2p/discover: hold table mutex in tests that read buckets directly #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
libotony merged 2 commits into from
Oct 26, 2026
Merged

p2p/discover: hold table mutex in tests that read buckets directly #1692

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6562d8e
p2p/discover: hold table mutex in tests that read buckets directly
libotony Oct 22, 2026
e7ab8dc
Merge branch 'master' into tony/discover-table-test-race
libotony Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions p2p/discover/table_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,8 @@ func TestTable_closest(t *testing.T) {
tab, _ := newTable(transport, test.Self, &net.UDPAddr{}, "", nil)
defer tab.Close()
tab.stuff(test.All)
tab.mutex.Lock()
defer tab.mutex.Unlock()

// check that doClosest(Target, N) returns nodes
result := tab.closest(test.Target, test.N).entries
Expand Down Expand Up @@ -291,8 +293,11 @@ func TestTable_ReadRandomNodesGetAll(t *testing.T) {
tab.stuff([]*Node{nodeAtDistance(tab.self.sha, ld)})
}
gotN := tab.ReadRandomNodes(buf)
if gotN != tab.len() {
t.Errorf("wrong number of nodes, got %d, want %d", gotN, tab.len())
tab.mutex.Lock()
wantN := tab.len()
tab.mutex.Unlock()
if gotN != wantN {
t.Errorf("wrong number of nodes, got %d, want %d", gotN, wantN)
return false
}
if hasDuplicates(buf[:gotN]) {
Expand Down
Loading