Repository navigation
p2p/discover: hold table mutex in tests that read buckets directly - #1692
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
libotony
marked this pull request as ready for review
October 22, 2026 10:47
otherview
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestTable_closestcallstab.closest(),tab.len()and walkstab.bucketswithout holdingtab.mutex, while the table's background revalidation goroutine maybump()entries under the lock at any time.closestdocuments that the caller must hold the mutex; every production caller does. With 5000 tables per run the race detector hits it occasionally, failing thetest_racejob (e.g. run 36824221890).Hold the mutex for the read-only checks after
stuff().TestTable_ReadRandomNodesGetAllhas the same unguardedlen()read; take the lock around that read only, sinceReadRandomNodeslocks internally.Test-only change. Before:
go test -race -count=10 -run TestTable_closest ./p2p/discoverfailed 1/10 locally; after: 0/30.