Skip to content

Fix contract pausing and transaction history pagination - #206

Merged
oluwaseyi1996-netizen merged 5 commits into
vatal-system:mainfrom
petermuazu:fix/four-reported-issues
Oct 20, 2026
Merged

oluwaseyi1996-netizen merged 5 commits into
vatal-system:mainfrom
petermuazu:fix/four-reported-issues

Conversation

@petermuazu

@petermuazu petermuazu commented Oct 20, 2026 •

Copy link
Copy Markdown

Closes #162
Closes #163
Closes #164
Closes #165

Summary

Add admin-controlled pause/unpause behavior to the escrow and dispute contracts, with guards on state-changing and fund-moving entry points. Add validated page/limit pagination and metadata to transaction history, and expose page navigation in the profile UI. Tighten deliverable upload validation. Align the reputation query with the generated Prisma schema so backend typechecking passes.

The Proposal and Deliverable models and their migration were already present in the starting branch, so no duplicate Prisma models or migration were added. Prisma validation and generation confirm those models are available.

Related issue

The four issue descriptions were provided without issue numbers.

Type of change

  • Bug fix
  • New feature
  • Documentation
  • Refactor / tests

How was it tested?

  • source "$HOME/.cargo/env" && cd contracts && cargo fmt --all -- --check && cargo clippy --all-targets -- -D warnings && cargo test --workspace — passed (98 tests).
  • cd backend && DATABASE_URL='postgresql://user:pass@localhost:5432/db' ./node_modules/.bin/prisma validate && DATABASE_URL='postgresql://user:pass@localhost:5432/db' ./node_modules/.bin/prisma generate — passed.
  • cd backend && npx tsc --noEmit — passed.
  • cd backend && npm test — passed (392 tests).
  • cd backend && npx eslint src/routes/users.ts src/routes/reputation.ts src/lib/schemas.ts src/lib/reputation.ts src/lib/contractErrors.ts src/openapi.ts src/__tests__/usersRoutes.test.ts src/__tests__/contractErrors.test.ts src/__tests__/reputationRoutes.test.ts — passed.
  • cd backend && npm run lint — failed on 39 existing repository-wide lint violations; the changed implementation files above pass targeted lint.
  • cd frontend && npm test — passed (360 tests).
  • cd frontend && npm run lint && npm run build — passed.

Checklist

  • Contracts: cd contracts && cargo fmt --all && cargo clippy --all-targets -- -D warnings && cargo test
  • Frontend: cd frontend && npm run lint && npx tsc --noEmit && npm run build
  • New contract functions have tests for both success and failure paths
  • Behaviour changes are reflected in README.md / CONTRIBUTING.md
  • Contract reference tables in README.md / CONTRIBUTING.md still match contracts/*/src/lib.rs (signatures, preconditions, same function set in both)
  • No secrets committed; testnet only

Wave complexity

  • Trivial
  • Medium
  • High

petermuazu and others added 4 commits October 20, 2026 13:37
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@drips-wave

drips-wave Bot commented Oct 20, 2026

Copy link
Copy Markdown

@petermuazu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@oluwaseyi1996-netizen
oluwaseyi1996-netizen merged commit 055d435 into vatal-system:main Oct 20, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants