Repository navigation
fix(contracts): format escrow test helper to resolve failing CI check - #208
Merged
oluwaseyi1996-netizen merged 4 commits intoOct 20, 2026
Conversation
oluwaseyi1996-netizen
merged commit Oct 20, 2026
caf931a
into
vatal-system:main
3 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it fixes
Fixes the failing CI workflow on
mainwhere the Contracts – fmt, clippy, test, wasm job failed during thecargo fmt --all -- --checkstep (e.g., GitHub Actions run #39443557135).Root cause
In PR #206 (
fix/four-reported-issues), the test helper functioncreate_rawwas added/updated incontracts/escrow/src/test.rsto parse XDR payloads viafrom_xdr. The invocation was formatted across multiple lines:Under standard
rustfmtrules (enforced by the stable toolchain pinned in.github/workflows/ci.yml), arguments of this length are collapsed into a single line. Because the pull request was merged without runningcargo fmt --all -- --check,mainentered a failing CI state on the formatting step.The fix and why
Ran
cargo fmt --allincontracts/, collapsing thefrom_xdrcall incontracts/escrow/src/test.rsinto its canonical Rustfmt representation:This directly resolves the formatting diff without altering any test logic or contract execution behavior.
How it was tested
cargo fmt --all -- --checkincontracts/— exited cleanly with code 0 and zero diff.npm run lint— passed with 0 errors/warnings.npx tsc --noEmit— passed with 0 type errors.npm test— all 361 unit/integration tests passed.npm run build— production build succeeded.npx prisma generate— generated client cleanly.npx tsc --noEmit— passed with 0 type errors.npm test -- ciWorkflows— all CI workflow configuration tests passed.Follow-up worth filing separately
cargo fmt --all -- --checklocally prior to opening PRs, preventing format regressions from reaching the integration branches.