Fix RESP3 auth health checks

tests/test_asyncio/test_credentials.py

@@ -132,6 +132,24 @@ async def test_only_pass_without_creds_provider(
 
         assert await r2.ping() is True
 
+    @pytest.mark.onlynoncluster
+    async def test_resp3_auth_with_health_check(
+        self, r_required_pass_teardown, create_valkey
+    ):
+        password = "password"
+        r = r_required_pass_teardown(password)
+        await init_required_pass(r, password)
+        assert await r.auth(password) is True
+
+        r2 = await create_valkey(
+            flushdb=False,
+            password=password,
+            protocol=3,
+            health_check_interval=10,
+        )
+
+        assert await r2.ping() is True
+
     async def test_user_and_pass_without_creds_provider(
         self, r_acl_teardown, create_valkey
     ):

tests/test_credentials.py

@@ -108,6 +108,23 @@ def test_only_pass_without_creds_provider(self, r, request):
 
         assert r2.ping() is True
 
+    @pytest.mark.onlynoncluster
+    def test_resp3_auth_with_health_check(self, r, request):
+        password = "password"
+        init_required_pass(r, request, password)
+        assert r.auth(password) is True
+
+        r2 = _get_client(
+            valkey.Valkey,
+            request,
+            flushdb=False,
+            password=password,
+            protocol=3,
+            health_check_interval=10,
+        )
+
+        assert r2.ping() is True
+
     def test_user_and_pass_without_creds_provider(self, r, request):
         """
         Test backward compatibility with username and password

valkey/asyncio/connection.py

@@ -383,7 +383,11 @@ async def on_connect(self) -> None:
                 self._parser.on_connect(self)
             if len(auth_args) == 1:
                 auth_args = ["default", auth_args[0]]
-            await self.send_command("HELLO", self.protocol, "AUTH", *auth_args)
+            # avoid checking health here -- PING will fail if we try
+            # to check the health prior to the AUTH
+            await self.send_command(
+                "HELLO", self.protocol, "AUTH", *auth_args, check_health=False
+            )
             response = await self.read_response()
             if response.get(b"proto") != int(self.protocol) and response.get(
                 "proto"

valkey/connection.py

@@ -383,7 +383,11 @@ def on_connect(self):
                 self._parser.on_connect(self)
             if len(auth_args) == 1:
                 auth_args = ("default", auth_args[0])
-            self.send_command("HELLO", self.protocol, "AUTH", *auth_args)
+            # avoid checking health here -- PING will fail if we try
+            # to check the health prior to the AUTH
+            self.send_command(
+                "HELLO", self.protocol, "AUTH", *auth_args, check_health=False
+            )
             response = self.read_response()
             # if response.get(b"proto") != self.protocol and response.get(
             #     "proto"