Skip to content

Fix RESP3 auth health checks - #339

Merged
bogdanp05 merged 1 commit into
valkey-io:mainfrom
9128305:fix-resp3-auth-health-checks-lsywmtkvpnwu-me
Sep 25, 2026
Merged

bogdanp05 merged 1 commit into
valkey-io:mainfrom
9128305:fix-resp3-auth-health-checks-lsywmtkvpnwu-me

Conversation

@9128305

@9128305 9128305 commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Skip health checks during RESP3 authentication,
matching the fix from redis/redis-py#3477. Fixes #188.

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

Skip health checks during RESP3 authentication, 
matching the fix from redis-py#3477. Fixes valkey-py#188.

Signed-off-by: 9128305 <129173596+9128305@users.noreply.github.com>

@bogdanp05 bogdanp05 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bogdanp05
bogdanp05 enabled auto-merge September 25, 2026 12:37
@codecov-commenter

codecov-commenter commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.79%. Comparing base (f3a73ec) to head (d5a42d5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #339   +/-   ##
=======================================
  Coverage   76.78%   76.79%           
=======================================
  Files         129      129           
  Lines       34288    34303   +15     
=======================================
+ Hits        26329    26343   +14     
- Misses       7959     7960    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bogdanp05
bogdanp05 merged commit 2f45571 into valkey-io:main Sep 25, 2026
86 checks passed
@9128305
9128305 deleted the fix-resp3-auth-health-checks-lsywmtkvpnwu-me branch September 25, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

AUTH errors on RESP 3 with health check interval > 0

3 participants