Skip to content

remove static designation on CEV broken functions #3727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethanglaser merged 3 commits into from
Aug 3, 2026
+7 −6
Merged

remove static designation on CEV broken functions #3727

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24f4434
remove static designation on CEV broken functions
ethanglaser Jul 29, 2026
dd8f9fd
block CEV errors for DPL inclusions
ethanglaser Jul 30, 2026
2142b47
Merge branch 'main' into dev/eglaser-cev-unused-func-template
Alexandr-Solovev Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cpp/daal/src/algorithms/dtrees/dtrees_model_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,10 +356,10 @@ void setProbabilities(const size_t treeId, const size_t nodeId, const size_t res
const double * const prob);

template <typename ClassOrResponseType>
static services::Status addLeafNodeInternal(const data_management::DataCollectionPtr & serializationData, const size_t treeId, const size_t parentId,
const size_t position, ClassOrResponseType response, double cover, size_t & res,
const data_management::DataCollectionPtr probTbl = data_management::DataCollectionPtr(),
const double * const prob = nullptr, const size_t nClasses = 0)
services::Status addLeafNodeInternal(const data_management::DataCollectionPtr & serializationData, const size_t treeId, const size_t parentId,
const size_t position, ClassOrResponseType response, double cover, size_t & res,
const data_management::DataCollectionPtr probTbl = data_management::DataCollectionPtr(),
const double * const prob = nullptr, const size_t nClasses = 0)
{
const size_t noParent = static_cast<size_t>(-1);
if (prob != nullptr)
Expand Down
4 changes: 2 additions & 2 deletions cpp/daal/src/algorithms/dtrees/dtrees_model_impl_common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,8 @@ bool traverseNodeDF(size_t level, size_t iRowInTable, const DecisionTreeNode * a
typedef services::Collection<size_t> NodeIdxArray;

template <typename OnSplitFunctor, typename OnLeafFunctor>
static bool traverseNodesBF(size_t level, NodeIdxArray & aCur, NodeIdxArray & aNext, const DecisionTreeNode * aNode, OnSplitFunctor & visitSplit,
OnLeafFunctor & visitLeaf)
bool traverseNodesBF(size_t level, NodeIdxArray & aCur, NodeIdxArray & aNext, const DecisionTreeNode * aNode, OnSplitFunctor & visitSplit,
OnLeafFunctor & visitLeaf)
{
for (size_t i = 0; i < aCur.size(); ++i)
{
Expand Down
1 change: 1 addition & 0 deletions cpp/oneapi/dal/backend/primitives/sort/sort_dpc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#pragma clang diagnostic ignored "-Wunused-local-typedef"
#pragma clang diagnostic ignored "-Wsign-compare"
#pragma clang diagnostic ignored "-Wkeyword-macro"
#pragma clang diagnostic ignored "-Wunused-template"

@david-cortes-intel david-cortes-intel Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this warning should be addressed instead of being ignored.

CC @Alexandr-Solovev .

@Alexandr-Solovev Alexandr-Solovev Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only way to address this issue is to create a ticket for DPL team, but it will likely block the current PR. @ethanglaser Could you please create a ticket for DPL team and and a remark here to remove such line when the task is done?

@ethanglaser ethanglaser Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this it outside of our library's scope otherwise I'd address it myself. Will post link to ticket once I create.


// Workaround: some oneTBB versions annotate the override of
// std::exception::what() with __TBB_EXPORTED_METHOD, which on Windows-x86
Expand Down
Loading