remove static designation on CEV broken functions - #3727
Conversation
|
/intelci: run |
|
@Vika-F Would this bring these functions into the ABI checks? |
@david-cortes-intel No, those changes should not affect the ABI as those functions are defined in cpp/daal/src (which contents are considered to have hidden visibility by default), and are not exported with DAAL_EXPORT. |
| #pragma clang diagnostic ignored "-Wunused-local-typedef" | ||
| #pragma clang diagnostic ignored "-Wsign-compare" | ||
| #pragma clang diagnostic ignored "-Wkeyword-macro" | ||
| #pragma clang diagnostic ignored "-Wunused-template" |
There was a problem hiding this comment.
It looks like this warning should be addressed instead of being ignored.
CC @Alexandr-Solovev .
There was a problem hiding this comment.
I think the only way to address this issue is to create a ticket for DPL team, but it will likely block the current PR. @ethanglaser Could you please create a ticket for DPL team and and a remark here to remove such line when the task is done?
There was a problem hiding this comment.
Yes, this it outside of our library's scope otherwise I'd address it myself. Will post link to ticket once I create.
|
/intelci: run |
FYI latest CEV run is in PR description. Still some errors on sklearnex build side, oneDAL build errors are resolved. |
david-cortes-intel
left a comment
There was a problem hiding this comment.
CI errors are in BasicStatistics, so probably not related to these changes.
There was a problem hiding this comment.
Pull request overview
This PR addresses a Windows build failure related to CEV by adjusting linkage on a couple of DAAL decision-tree helper templates and by silencing a Clang warning in the oneAPI DPC++ sort implementation.
Changes:
- Suppress Clang
-Wunused-templatewarnings around the DPL kernel template include in the DPC++ sort primitive. - Remove
static(internal linkage) from two DAAL templated helper functions used in decision tree model code.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cpp/oneapi/dal/backend/primitives/sort/sort_dpc.cpp | Adds a Clang diagnostic suppression for -Wunused-template in the existing diagnostic push/pop block. |
| cpp/daal/src/algorithms/dtrees/dtrees_model_impl.h | Removes static from addLeafNodeInternal template helper. |
| cpp/daal/src/algorithms/dtrees/dtrees_model_impl_common.h | Removes static from traverseNodesBF template helper. |
Description
Resolves new failure in windows build for CEV (http://intel-ci.intel.com/f18af139-44fd-f1df-b2e8-d4f5ef20c6a0)
Run on this branch: http://intel-ci.intel.com/f18c4750-506a-f12c-874f-d4f5ef20c6a0
Checklist:
Completeness and readability
Testing
Performance