Skip to content

fix: Swap the trt_llm_backend base image default off py3-min - #863

Merged
mc-nv merged 1 commit into
mainfrom
mchornyi/TRI-1930/inference-image
Oct 5, 2026
Merged

mc-nv merged 1 commit into
mainfrom
mchornyi/TRI-1930/inference-image

Conversation

@mc-nv

@mc-nv mc-nv commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

What does the PR do?

  • Dockerfile.triton.trt_llm_backend's BASE_IMAGE default still pointed at
    tritonserver:25.12-py3-min, the image being retired.
  • Points it at the published cuda-dl-base equivalent of the same train
    (25.12-cuda13.1-devel-ubuntu24.04, confirmed on NGC) — an image-family swap
    only, no version bump.

Where should the reviewer start?

  • dockerfile/Dockerfile.triton.trt_llm_backend line 1.

Related PRs:

Related Issues:

  • Resolves: TRI-1930

The Dockerfile's BASE_IMAGE default still pointed at the py3-min image being
retired. CI already overrides it with a CUDA devel image of the same train
(ci/tensorrtllm_backend/tensorrtllm-ci.yml), so this default only affects a
hand-run local docker build.

Point it at the published cuda-dl-base equivalent of the train it already
named, keeping the version fixed so this is an image-family swap only.
@greptile-apps

greptile-apps Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[High risk] Changes the base container image for the inference backend.

The PR is not safe to merge as a default image change until the resulting image includes Triton Inference Server.

Findings

  1. P1 Triton server runtime is missing ▶

Summary

The PR changes the default Docker base from the Triton Server image to a same-train CUDA deep-learning base image. The Dockerfile still relies on its base to supply Triton Server, so the default build no longer produces the documented runnable server image.

Reviews (1) · Last reviewed commit: "fix: Swap the trt_llm_backend base image..."

Comment thread dockerfile/Dockerfile.triton.trt_llm_backend
@mc-nv
mc-nv requested review from Vinya567, nv-rinig and whoisj October 2, 2026 18:57
@mc-nv
mc-nv merged commit 04173aa into main Oct 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug fix (fix: PRs)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants