Repository navigation
fix: Require TRITON_BUILD_CONTAINER instead of synthesizing a py3-min image - #125
Merged
Merged
Conversation
… image
When only TRITON_BUILD_CONTAINER_VERSION was given, the build container was
invented as nvcr.io/nvidia/tritonserver:${VERSION}-py3-min. That image is
being retired, so the fallback is a latent failure: configure succeeds and the
build dies much later on a docker pull 404 for an image nobody asked for.
Stop inventing one. TRITON_BUILD_CONTAINER is now required on all platforms,
which turns a missing image into a configure-time error that names exactly
what to supply. TRITON_BUILD_CONTAINER_VERSION had no other use in this repo,
so it goes with it, and the WIN32 and either-or guards collapse into one.
Nothing is lost by making the caller name the image: tools/gen_openvino_dockerfile.py
emits only FROM ${BASE_IMAGE} and WORKDIR before apt-installing its own
dependencies, with no reference to tritonserver paths, and this backend forces
TRITON_ENABLE_GPU OFF so it does not need CUDA either.
Breaking for standalone cmake builds: configuring with only
-DTRITON_BUILD_CONTAINER_VERSION now fails with "TRITON_BUILD_CONTAINER is
required". The README example is updated in the same commit so the documented
path does not point at a removed variable. Builds driven by server/build.py
are unaffected -- it always passes a resolved image.
 |
Contributor
Author
|
FYI : @dtrawins |
whoisj
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
TRITON_BUILD_CONTAINER_VERSIONinventedtritonserver:${VERSION}-py3-min, an image being retired — configuresucceeded and the build died later on a
docker pull404.TRITON_BUILD_CONTAINERinstead, making it a configure-time error.TRITON_BUILD_CONTAINER_VERSIONonly fed that synthesis, so it goes too, andtwo guards collapse into one.
Standalone
cmakebuilds passing only-DTRITON_BUILD_CONTAINER_VERSIONnowfail with
TRITON_BUILD_CONTAINER is required. This is the intent — loudand immediate, rather than an opaque 404 once py3-min is withdrawn. The README
example is updated in the same commit so the documented path never references
a removed variable.
Builds driven by
server/build.pyare unaffected: it always passes aresolved image.
Why requiring it is safe here
tools/gen_openvino_dockerfile.pyemits onlyFROM ${BASE_IMAGE}andWORKDIR /workspacebefore apt-installing its own dependencies — zeroreferences to
tritonserveror/opt/tritonserver.CMakeLists.txtalsoforces
TRITON_ENABLE_GPU OFF, so this backend does not even need CUDA.Nothing is lost by making the caller name the image.
Where should the reviewer start?
CMakeLists.txt— the removed synthesis and the singleFATAL_ERRORguard.Test plan
Verified with
cmake4.4.3:TRITON_BUILD_CONTAINER-DTRITON_BUILD_CONTAINER_VERSION=25.11only-DTRITON_BUILD_CONTAINER=<image>Also
./build.py --dryrun --enable-gpu --backend openvinoinserver: thegenerated
cmake_buildcarriesTRITON_BUILD_CONTAINER=nvcr.io/nvidia/cuda-dl-base:26.09-cuda13.4-devel-ubuntu24.04,confirming
build.pynever relied on the removed fallback.Related PRs:
Related Issues: