feat: add QUERY method routing - #3801
Merged
Merged
Conversation
Add `MethodFilter::QUERY`, `routing::query[_service]` and `MethodRouter::query[_service]`
Contributor
Author
|
CI will fail until hyperium/http#798 in release |
yunz-dev
commented
Jun 17, 2026
| pub const TRACE: Self = Self::from_bits(0b1_0000_0000); | ||
| pub const TRACE: Self = Self::from_bits(0b01_0000_0000); | ||
| /// Match `QUERY` requests. | ||
| pub const QUERY: Self = Self::from_bits(0b10_0000_0000); |
Contributor
Author
There was a problem hiding this comment.
Unsure if the bit mask is meant to follow a certain protocol or it doesn’t matter.
|
I'like to add more sections of RFC if not implemented yet. |
This comment has been minimized.
This comment has been minimized.
aatifsyed
approved these changes
Jul 29, 2026
Contributor
Author
|
Seems like http v1.5.0 is released, I'll fix this up when I get home. |
yunz-dev
force-pushed
the
main
branch
2 times, most recently
from
August 1, 2026 12:56
28bc7b0 to
dcab719
Compare
Collaborator
|
It's not enough to update cargo.lock, you have to bump the version in cargo.toml too since this is a new .minimum version we require to compile. That's why the msrv check fails, which actually also checks minimum dependency versions. |
Contributor
Author
ahh.. right. Silly me haha. Should be fixed now |
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
MethodFilter::QUERY,routing::query[_service]andMethodRouter::query[_service]andRouterExt::typed_queryMotivation
Solution
While developing I put this in the root
Config.toml