feat(routing): support the HTTP QUERY method - #3837
Closed
farrosfr wants to merge 2 commits into
Closed
Conversation
Add MethodFilter::QUERY and corresponding routing helpers query and query_service to allow handling requests using the standardized HTTP QUERY method (RFC 10008). Refs: tokio-rs#3799
1 task
Collaborator
|
There's already #3801 which waits for upstream You can check that PR and discuss there if you think anything else is missing in the implementation. |
Contributor
Author
|
Thanks @mladedav I am sorry because I didn't check for existing open PRs before submitting. Okay i will check if there is any need for implementation in that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(routing): support HTTP QUERY method (RFC 10008)
Resolves #3799.
Overview
Adds routing filters, handlers, and typed routing support for the newly standardized HTTP
QUERYmethod (RFC 10008).Changes
axumMethodFilter::QUERY: Defined a new bitflag (0b10_0000_0000).TryFrom<Method> for MethodFilter: Added fallback matching (other if other.as_str() == "QUERY").MethodRouter:query: MethodEndpoint<S, E>field.queryandquery_servicefunctions..query(handler)and.query_service(service)methods.call!macro to match"QUERY"string slices for routing..request(method, url)to the test client and an integration test verifying thatQUERYrequests route to thequeryhandler.axum-extraRouterExt::typed_query: Implemented typed routing support forQUERYrequests onTypedPath.Compatibility Notes
Because the
httpcrate has not yet released a new version containingMethod::QUERY, the implementation uses string comparisons (req.method().as_str() == "QUERY"). This compiles on current stable dependencies and remains forward-compatible.