Skip to content

schedule: ll: handle completed task state in library scheduler #11128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
singalsu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

schedule: ll: handle completed task state in library scheduler #11128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions src/platform/library/schedule/ll_schedule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ void schedule_ll_run_tasks(void)
{
struct list_item *tlist, *tlist_;
struct task *task;
enum task_state state;

/* list empty then return */
if (list_is_empty(&sched_list))
Expand All @@ -44,12 +45,14 @@ void schedule_ll_run_tasks(void)
if (task->state == SOF_TASK_STATE_QUEUED) {
task->state = SOF_TASK_STATE_RUNNING;

task->ops.run(task->data);
state = task_run(task);

/* only re-queue if not cancelled */
if (task->state == SOF_TASK_STATE_RUNNING)
if (state == SOF_TASK_STATE_COMPLETED) {
task->state = SOF_TASK_STATE_COMPLETED;
list_item_del(&task->list);
} else if (task->state == SOF_TASK_STATE_RUNNING) {
task->state = SOF_TASK_STATE_QUEUED;

}
}
}
}
Expand All @@ -58,6 +61,10 @@ void schedule_ll_run_tasks(void)
static int schedule_ll_task(void *data, struct task *task, uint64_t start,
uint64_t period)
{
if (task->state == SOF_TASK_STATE_QUEUED ||
task->state == SOF_TASK_STATE_RUNNING)
return 0;

/* add task to list */
list_item_prepend(&task->list, &sched_list);
task->state = SOF_TASK_STATE_QUEUED;
Expand All @@ -76,18 +83,24 @@ static void ll_scheduler_free(void *data, uint32_t flags)
/* TODO: scheduler free and cancel APIs can merge as part of Zephyr */
static int schedule_ll_task_cancel(void *data, struct task *task)
{
if (task->state == SOF_TASK_STATE_QUEUED ||
task->state == SOF_TASK_STATE_RUNNING)
list_item_del(&task->list);

/* delete task */
task->state = SOF_TASK_STATE_CANCEL;
list_item_del(&task->list);

return 0;
}

/* TODO: scheduler free and cancel APIs can merge as part of Zephyr */
static int schedule_ll_task_free(void *data, struct task *task)
{
if (task->state == SOF_TASK_STATE_QUEUED ||
task->state == SOF_TASK_STATE_RUNNING)
list_item_del(&task->list);

task->state = SOF_TASK_STATE_FREE;
list_item_del(&task->list);

return 0;
}
Expand Down
Loading