schedule: ll: handle completed task state in library scheduler - #11128
Open
singalsu wants to merge 1 commit into
Open
schedule: ll: handle completed task state in library scheduler#11128singalsu wants to merge 1 commit into
singalsu wants to merge 1 commit into
Conversation
Update the library LL scheduler in schedule_ll_run_tasks() to check the task_run() return state and remove tasks returning SOF_TASK_STATE_COMPLETED from the scheduler list. Following commit 002e499 ("ipc4: pipeline: split trigger and copy processing"), IPC4 uses a one-shot trigger task that returns SOF_TASK_STATE_COMPLETED upon trigger completion, while the copy task waits for task_is_active(p->trigger_task) to clear before copying. Previously, the library LL scheduler ignored the return value of task_run() and reset the task state back to SOF_TASK_STATE_QUEUED, leaving trigger_task permanently active and causing testbench pipeline copy tasks to stall indefinitely. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
marked this pull request as ready for review
August 25, 2026 15:51
singalsu
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
August 25, 2026 15:51
serhiy-katsyuba-intel
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the library LL scheduler in schedule_ll_run_tasks() to check the task_run() return state and remove tasks returning SOF_TASK_STATE_COMPLETED from the scheduler list.
Following commit 002e499 ("ipc4: pipeline: split trigger and copy processing"), IPC4 uses a one-shot trigger task that returns SOF_TASK_STATE_COMPLETED upon trigger completion, while the copy task waits for task_is_active(p->trigger_task) to clear before copying. Previously, the library LL scheduler ignored the return value of task_run() and reset the task state back to SOF_TASK_STATE_QUEUED, leaving trigger_task permanently active and causing testbench pipeline copy tasks to stall indefinitely.