Skip to content

Instrument flaky test: TestWorkflowTaskAndActivityTaskTimeoutsWorkflow #9137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dandavison merged 9 commits into from
Jan 26, 2026
Merged

Instrument flaky test: TestWorkflowTaskAndActivityTaskTimeoutsWorkflow #9137

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
93a277e
CI: run flaky test 20 times to reproduce timeout
dandavison Jan 26, 2026
d12f163
Add instrumentation to diagnose flaky timeout test
dandavison Jan 26, 2026
c054a94
CI: remove docker deps for sqlite test
dandavison Jan 26, 2026
7c8adab
CI: set PERSISTENCE_TYPE=sql for sqlite tests
dandavison Jan 26, 2026
ef07e28
CI: add CPU stress and run full suite to reproduce flakiness
dandavison Jan 26, 2026
cb42782
CI: increase stress and add more test suites for contention
dandavison Jan 26, 2026
7a7efd1
CI: try GOMAXPROCS=1 with count=3 per job (60 total runs)
dandavison Jan 26, 2026
88a4764
Add diagnostic logging for flaky timeout test
dandavison Jan 26, 2026
a55a2e7
revert debug workflow
dandavison Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions tests/workflow_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1289,14 +1289,34 @@ func (s *WorkflowTestSuite) TestWorkflowTaskAndActivityTaskTimeoutsWorkflow() {
T: s.T(),
}

@dandavison dandavison Jan 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lines below are the only change in this PR. They are intended to

  • provide helpful information for debugging next time this occurs
  • be prefixed apropriately so it is clear to what test they refer to

My intention is that this change will be reverted when we fix the flakiness.

// This test is flaky: it has been seen to cause the 35m test timeout to be exceeded
// occasionally. It currently has atypically detailed info-level logging with the aim of
// diagnosing the reason for the timeout.
const testTag = "[TestWorkflowTaskAndActivityTaskTimeoutsWorkflow] "
testStart := time.Now()
var lastDropTime time.Time
for i := 0; i < 8; i++ {
iterStart := time.Now()
dropWorkflowTask := (i%2 == 0)
s.Logger.Info("Calling Workflow Task", tag.Counter(i))
s.Logger.Info(testTag+"iteration starting",
tag.Counter(i),
tag.NewBoolTag("drop_task", dropWorkflowTask),
tag.NewDurationTag("time_since_test_start", time.Since(testStart)),
tag.NewDurationTag("time_since_last_drop", time.Since(lastDropTime)))
var err error
if dropWorkflowTask {
_, err = poller.PollAndProcessWorkflowTask(testcore.WithDumpHistory, testcore.WithDropTask)
lastDropTime = time.Now()
s.Logger.Info(testTag+"dropped workflow task",
tag.Counter(i),
tag.NewDurationTag("poll_duration", time.Since(iterStart)))
} else {
_, err = poller.PollAndProcessWorkflowTask(testcore.WithDumpHistory, testcore.WithExpectedAttemptCount(2))
s.Logger.Info(testTag+"processed workflow task (expected attempt=2)",
tag.Counter(i),
tag.NewDurationTag("poll_duration", time.Since(iterStart)),
tag.NewDurationTag("time_since_last_drop", time.Since(lastDropTime)),
tag.Error(err))
}
if err != nil {
s.PrintHistoryEventsCompact(s.GetHistory(s.Namespace().String(), &commonpb.WorkflowExecution{
Expand All @@ -1306,13 +1326,18 @@ func (s *WorkflowTestSuite) TestWorkflowTaskAndActivityTaskTimeoutsWorkflow() {
}
s.True(err == nil || errors.Is(err, testcore.ErrNoTasks))
if !dropWorkflowTask {
s.Logger.Info("Calling PollAndProcessActivityTask", tag.Counter(i))
activityStart := time.Now()
s.Logger.Info(testTag+"polling activity task", tag.Counter(i))
err = poller.PollAndProcessActivityTask(i%4 == 0)
s.Logger.Info(testTag+"activity task poll completed",
tag.Counter(i),
tag.NewDurationTag("activity_poll_duration", time.Since(activityStart)),
tag.Error(err))
s.True(err == nil || errors.Is(err, testcore.ErrNoTasks))
}
}

s.Logger.Info("Waiting for workflow to complete", tag.WorkflowRunID(we.RunId))
s.Logger.Info(testTag+"waiting for workflow to complete", tag.WorkflowRunID(we.RunId))

s.False(workflowComplete)
_, err := poller.PollAndProcessWorkflowTask(testcore.WithDumpHistory)
Expand Down
Loading