Repository navigation
Instrument flaky test: TestWorkflowTaskAndActivityTaskTimeoutsWorkflow - #9137
Merged
dandavison merged 9 commits intoJan 26, 2026
Merged
Conversation
Attempting to reproduce TestWorkflowTaskAndActivityTaskTimeoutsWorkflow timing out after 35m in CI.
dandavison
force-pushed
the
fix-flaky-task-timeouts-test
branch
from
January 26, 2026 14:05
36def4b to
93a277e
Compare
Log timing and attempt count info to understand what happens when TestWorkflowTaskAndActivityTaskTimeoutsWorkflow times out in CI.
SQLite functional tests don't need external services. The previous workflow failed because all 20 parallel jobs tried to bind port 9200.
The Makefile defaults to nosql/cassandra. Need both env vars.
Running full WorkflowTestSuite (15 parallel tests) with CPU stress to simulate CI load conditions that may cause 1-second timeouts to misfire.
Run multiple timing-sensitive suites (WorkflowTestSuite, TransientTaskTestSuite, StickyTQTestSuite) with heavy CPU+IO+VM stress to reproduce flakiness.
Constrain to single OS thread to expose timing bugs where goroutines don't get scheduled promptly during the 1-second timeout windows.
Add timing instrumentation to TestWorkflowTaskAndActivityTaskTimeoutsWorkflow to help diagnose what happens when the test times out in CI. All log lines are prefixed with the test name to distinguish them from other concurrent tests. Reverts taskpoller.go changes to avoid affecting other tests.
dandavison
force-pushed
the
fix-flaky-task-timeouts-test
branch
from
January 26, 2026 17:21
741dbce to
a55a2e7
Compare
dandavison
changed the title
dandavison
commented
Jan 26, 2026
| @@ -1289,14 +1289,34 @@ func (s *WorkflowTestSuite) TestWorkflowTaskAndActivityTaskTimeoutsWorkflow() { | |||
| T: s.T(), | |||
| } | |||
|
|
|||
Contributor
Author
There was a problem hiding this comment.
The lines below are the only change in this PR. They are intended to
- provide helpful information for debugging next time this occurs
- be prefixed apropriately so it is clear to what test they refer to
My intention is that this change will be reverted when we fix the flakiness.
stephanos
approved these changes
Jan 26, 2026
dandavison
enabled auto-merge (squash)
January 26, 2026 17:35
spkane31
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tested by:
Note
Instruments the flaky
TestWorkflowTaskAndActivityTaskTimeoutsWorkflowwith detailed info-level logging to help diagnose intermittent 35m timeouts.testTag, iteration timers, and last-drop tracking; logs iteration starts, task drops/processing (with expected attempt), activity polling durations, and errorsWritten by Cursor Bugbot for commit a55a2e7. This will update automatically on new commits. Configure here.