Repository navigation
Move every unreleased SDK change log entry to 1.43 and fix version markers - #1544
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
#1541 added SDK entries for 1.41 and 1.42, which will never be tagged: the next shared release is 1.43.0. Fold the Go 1.41 Breaking items into the Go 1.43 entry, rename the Python, TypeScript, Rust, and Java entries to 1.43, and fix the version markers: Python FlowConfig is changed in 1.43.0, and the Go ErrorWithStack change already shipped in 1.40.2.
longquanzheng
changed the title
Contributor
Author
|
Review record: an independent reviewer checked the diff against origin/main and the release tags. Verdict: APPROVE, no blockers. Verified: the next shared version is 1.43.0; each SDK change log has exactly one unreleased entry, headed 1.43, with no lost content; the ErrorWithStack marker matches tag sdk-go/v1.40.2; no stale 1.41 or 1.42 markers remain. An earlier review found the conflict with #1541, which the merge commit resolves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewStandaloneContextand fold the 1.41 Breaking items from Remove Continue-As-New and InternalHandlerTimeout; rename FlowExecutionID to FlowRunID #1541 into it. Change theNewStandaloneContextandStandaloneContextOptionsdoc comments from "Since 1.41.0" to "Since 1.43.0".## 1.41entry to## 1.43. Java: rename the unreleased## 1.42entry to## 1.43.FlowConfig:versionchanged:: 1.41.0becomes1.43.0.ErrorWithStack: "Changed in 1.41.0" becomes "Changed in 1.40.2", the release that already shipped it (the comment is present at tagsdk-go/v1.40.2, and the Go change log says the change arrived in 1.40.2).Why
The next shared release version is 1.43.0, because web and cli already shipped 1.42.0.
script/release/changed_components.py 1.43.0on current main selects all five SDKs, web, and cli, so the SDK changes from #1521 and #1541 ship as 1.43.0, and no SDK will be tagged 1.41 or 1.42. Release rules require each component's change log entry for the release on main before tagging, because the release snapshots the Developer reference from main.Testing
go build ./dexandgofmt -l dexinsdk-go.cd docs && npm run checkpassed after merging main.