Repository navigation
SDKs: mark the Join helper as since 1.44.0 after the 1.43.0 release - #1564
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Marks the Join helper (and Java's
Listoverloads ofStepDecision.goToManyandRPCResult.of) as Since 1.44.0 and moves their change log entries from the released## 1.43section to a new unreleased## 1.44section in the Go, Java, Python, Rust, and TypeScript references.join.go; JavaJoin.java,JoinRound.java,RPCResult.java,StepDecision.java; Pythonjoin.py,flow.py(PersistenceSchema.of); Rustjoin.rs,persistence.rs; TypeScriptjoin.ts,persistence.ts.standalone_context.go, Pythonflow_config.py).## 1.43section now matches its content at thesdk-<lang>/v1.43.0tag (apart from the release line written after tagging).Why
sdk-{go,python,java,typescript,rust}/v1.43.0were tagged at b76d1da (#1544) before the Join helper PRs (#1549, #1550, #1552, #1553, #1554) merged, so 1.43.0 does not contain them, but those PRs had placed their entries under the released 1.43 section and marked the API 1.43.0.doc-map: no change needed: version markers and change log placement only
Testing
make docsCheck, Pythonscripts/check_public_docs.py, Rustmake docs-check, TypeScriptnpm run docs:check, Java./gradlew javadoc,cd docs && npm run check.## 1.43section with the tag.