Skip to content

Upgrade to Electron 43 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandboxcoder merged 4 commits into from
Aug 27, 2026
Merged

Upgrade to Electron 43 #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0da1852
Upgrade to Electron 43
sandboxcoder Aug 25, 2026
d628402
fix set-output deprecation
sandboxcoder Aug 25, 2026
06bcfbf
update yarn.lock for electron43
sandboxcoder Aug 27, 2026
d4bd5be
wrap GITHUB_OUTPUT in quotes
sandboxcoder Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ env:
BUILD_DIRECTORY: "build"
DISTRIBUTE_DIRECTORY: "distribute"
RELEASE_BUCKET: "obs-studio-deployment"
ELECTRON_VERSION: "v29.4.3"
ELECTRON_VERSION: "v43.2.0"

permissions:
contents: read

jobs:
build:
name: 'Build a package'
runs-on: windows-latest
runs-on: windows-2022
steps:
- uses: actions/checkout@v3
- name: Show GitHub context
Expand All @@ -36,12 +36,12 @@ jobs:
run: echo "$GITHUB_CONTEXT"
- name: Get the version
id: get_version
run: echo ::set-output name=VERSION::${GITHUB_REF/refs\/tags\//}
run: echo "VERSION=${GITHUB_REF/refs\/tags\//}" >> "$GITHUB_OUTPUT"
shell: bash
- name: Install Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: '16.x'
node-version: '24.x'
- name: Install dependencies
run: yarn install --immutable --immutable-cache --check-cache
Comment on lines +42 to 46
Comment on lines 45 to 46
- name: Add MSBuild to PATH
Expand All @@ -66,7 +66,7 @@ jobs:
upload_debug_symbols:
needs: build
name: 'Upload debug symbols'
runs-on: windows-latest
runs-on: windows-2022
if: startsWith(github.ref, 'refs/tags/')
steps:
- name: Get the version of aws cli
Expand Down Expand Up @@ -108,12 +108,12 @@ jobs:
upload_release_package:
needs: build
name: 'Upload release package'
runs-on: windows-latest
runs-on: windows-2022
if: startsWith(github.ref, 'refs/tags/')
steps:
- name: Get the version
id: get_version
run: echo ::set-output name=VERSION::${GITHUB_REF/refs\/tags\//}
run: echo "VERSION=${GITHUB_REF/refs\/tags\//}" >> "$GITHUB_OUTPUT"
shell: bash
- name: Get build from cache
id: cache-check
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/cmake")

SET(NODEJS_URL "https://artifacts.electronjs.org/headers/dist" CACHE STRING "Node.JS URL")
SET(NODEJS_NAME "iojs" CACHE STRING "Node.JS Name")
SET(NODEJS_VERSION "v29.4.3" CACHE STRING "Node.JS Version")
SET(NODEJS_VERSION "v43.2.0" CACHE STRING "Node.JS Version")
Comment on lines 10 to +12

include(NodeJS)

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"main": "main.js",
"devDependencies": {
"colors": "^1.4.0",
"electron": "29.4.3",
"electron": "43.2.0",
Comment thread
sandboxcoder marked this conversation as resolved.
"fs": "^0.0.1-security",
"path": "^0.12.7",
"node-addon-api": "^7.1.1",
Expand Down
Loading
Loading