Repository navigation
Upgrade to Electron 43 - #25
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project’s Electron toolchain and CI configuration to build against Electron 43, aligning local/package dependencies, native-module header fetching, and the Windows GitHub Actions build environment.
Changes:
- Bumps Electron dependency from 29.4.3 to 43.2.0.
- Updates CMake header download/version configuration to match Electron 43.2.0.
- Updates GitHub Actions build workflow environment (Electron version, Windows runner, setup-node action + Node version).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Updates the Electron devDependency to 43.2.0. |
| CMakeLists.txt | Updates the header/version variable used for downloading Electron/Node headers to v43.2.0. |
| .github/workflows/build.yml | Updates CI environment for Electron 43.2.0 and modernizes runner/setup-node settings. |
Suppressed comments (1)
.github/workflows/build.yml:117
- Same as above:
::set-outputis deprecated and should be replaced with writing to$GITHUB_OUTPUT.
- name: Get the version
id: get_version
run: echo ::set-output name=VERSION::${GITHUB_REF/refs\/tags\//}
shell: bash
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
37
to
40
| - name: Get the version | ||
| id: get_version | ||
| run: echo ::set-output name=VERSION::${GITHUB_REF/refs\/tags\//} | ||
| shell: bash |
Comment on lines
10
to
+12
| SET(NODEJS_URL "https://artifacts.electronjs.org/headers/dist" CACHE STRING "Node.JS URL") | ||
| SET(NODEJS_NAME "iojs" CACHE STRING "Node.JS Name") | ||
| SET(NODEJS_VERSION "v29.4.3" CACHE STRING "Node.JS Version") | ||
| SET(NODEJS_VERSION "v43.2.0" CACHE STRING "Node.JS Version") |
summeroff
approved these changes
Aug 25, 2026
aleksandr-voitenko
approved these changes
Aug 25, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
Suppressed comments (1)
.github/workflows/build.yml:116
$GITHUB_OUTPUTcan contain a path with spaces on Windows; redirecting without quotes is brittle. Quote the variable in the redirection target.
run: echo "VERSION=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_OUTPUT
Comment on lines
3
to
+7
| "version": "1.0.7", | ||
| "main": "main.js", | ||
| "devDependencies": { | ||
| "colors": "^1.4.0", | ||
| "electron": "29.4.3", | ||
| "electron": "43.2.0", |
Comment on lines
+42
to
46
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '16.x' | ||
| node-version: '24.x' | ||
| - name: Install dependencies | ||
| run: yarn install --immutable --immutable-cache --check-cache |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
package.json:8
- This change upgrades the repo to a Yarn Berry-style lockfile, but
package.jsondoesn't declare apackageManager(Yarn version) to ensure consistent installs across dev machines/CI via Corepack. Without pinning, contributors may run a different Yarn major and either fail installs or churnyarn.lockunexpectedly.
"devDependencies": {
"colors": "^1.4.0",
"electron": "43.2.0",
"fs": "^0.0.1-security",
Comment on lines
45
to
46
| - name: Install dependencies | ||
| run: yarn install --immutable --immutable-cache --check-cache |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.