Skip to content

feat: init errors/warnings go to stderr #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Peeja wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: init errors/warnings go to stderr #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions scripts/init.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ fi

# Step 3: Check for mkdelegation (needed for proof generation)
echo ""
echo "Step 3: Checking for mkdelegation..."
echo "Step 2: Checking for mkdelegation..."
# Check for mkdelegation
MKDELEGATION="${MKDELEGATION:-mkdelegation}"
if ! command -v "$MKDELEGATION" &> /dev/null; then
Expand All @@ -52,9 +52,11 @@ if ! command -v "$MKDELEGATION" &> /dev/null; then
go install github.com/storacha/go-mkdelegation@latest
echo " mkdelegation installed successfully"
else
echo "WARNING: Go not found. Cannot install mkdelegation."
echo " Proof generation will be skipped."
echo " Install manually: go install github.com/storacha/go-mkdelegation@latest"
{
echo "WARNING: Go not found. Cannot install mkdelegation."
echo " Proof generation will be skipped."
echo " Install manually: go install github.com/storacha/go-mkdelegation@latest"
} >/dev/stderr
fi
fi
fi
Expand All @@ -70,8 +72,10 @@ if [[ -x "$GENERATED_DIR/generate-proofs.sh" ]]; then
echo " Skipping proof generation (mkdelegation not available)"
fi
else
echo "WARNING: generate-proofs.sh not found or not executable"
echo " Proof generation will be skipped."
{
echo "WARNING: generate-proofs.sh not found or not executable"
echo " Proof generation will be skipped."
} >/dev/stderr
fi
Comment on lines 55 to 79

@frrist frrist Apr 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've made a mistake in the implementation here, we should still print this error, but we should failed the entire operation if go isn't installed on the system. Now that #9 has landed go is structly required to use smelt since we use if for code generation.


# Step 5: Create Docker network
Expand Down