feat: init errors/warnings go to stderr - #11
Open
Peeja wants to merge 1 commit into
Open
Conversation
frrist
reviewed
Apr 16, 2026
Comment on lines
55
to
79
| @@ -70,8 +72,10 @@ if [[ -x "$GENERATED_DIR/generate-proofs.sh" ]]; then | |||
| echo " Skipping proof generation (mkdelegation not available)" | |||
| fi | |||
| else | |||
| echo "WARNING: generate-proofs.sh not found or not executable" | |||
| echo " Proof generation will be skipped." | |||
| { | |||
| echo "WARNING: generate-proofs.sh not found or not executable" | |||
| echo " Proof generation will be skipped." | |||
| } >/dev/stderr | |||
| fi | |||
Member
There was a problem hiding this comment.
I think I've made a mistake in the implementation here, we should still print this error, but we should failed the entire operation if go isn't installed on the system. Now that #9 has landed go is structly required to use smelt since we use if for code generation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a little QOL.