Skip to content

fix(ui): configure React Query provider - #86

Merged
SharifIbrahimDev merged 1 commit into
sharif-stellar-tools:masterfrom
WilliamK112:fix/react-query-provider
Oct 13, 2026
Merged

SharifIbrahimDev merged 1 commit into
sharif-stellar-tools:masterfrom
WilliamK112:fix/react-query-provider

Conversation

@WilliamK112

Copy link
Copy Markdown
Contributor

Closes #63

What changed

  • replace legacy react-query v3 with @tanstack/react-query
  • migrate useTransactionHistory to the v5 object API
  • add the Vite/React application entry point
  • create a QueryClient and wrap Dashboard with QueryClientProvider
  • add the missing index.html

Why

Dashboard calls the transaction-history hook, but the repository did not mount the React application or provide a query client. The existing build also failed because there was no index.html entry point.

Verification

  • npm ci
  • npm test -- --runInBand — 79 tests passed
  • npm run build — passed
  • browser smoke test — dashboard rendered 12 transaction rows and filter controls with the expected page title and zero console errors

AI-assisted implementation and verification.

@WilliamK112

Copy link
Copy Markdown
Contributor Author

CI note: the only failing check is the repository's PR Automation / pr-review workflow. Its Welcome Contributor step fails before any project validation because actions/github-script receives HTTP 403 Resource not accessible by integration while trying to create a PR comment.

This is a workflow-token permission issue, not a failure in this change. The implementation was locally validated with all 79 tests and the production build. Could a maintainer update the workflow permissions/trusted-event handling and rerun the check when convenient?

@WilliamK112
WilliamK112 force-pushed the fix/react-query-provider branch from 4dbf6bb to 4216bcc Compare August 13, 2026 11:28
@WilliamK112

Copy link
Copy Markdown
Contributor Author

Rebased this PR onto current master (a8efb23) and resolved the entry-point conflicts by preserving the newly merged dashboard/subscription work while retaining only the React Query provider and v5 hook migration. The PR diff is back to the intended four files. Validation: all 136 tests pass and git diff --check master...HEAD passes. npm run build currently stops on src/subscriptions/horizonSubscription.ts:192; I reproduced the identical TypeScript error in a separate clean master worktree, so it is a current baseline issue from the newly merged subscription code rather than this PR.

@WilliamK112

Copy link
Copy Markdown
Contributor Author

CI note: the only failing check is the repository-level pr-review welcome job, not this PR's code. The job receives a read-only GITHUB_TOKEN (contents: read, pull-requests: read) and then calls issues.createComment, which GitHub rejects with 403 Resource not accessible by integration.

The failing run is https://github.com/sharif-stellar-tools/sharif-chain-scope/actions/runs/31695680845/job/94432806668.

A maintainer-side workflow fix would be to grant the job issues: write (or pull-requests: write, depending on the chosen API) while keeping other permissions minimal, or to skip the welcome-comment step when the token cannot write. I have not added an unrelated workflow change to this feature branch.

@SharifIbrahimDev
SharifIbrahimDev merged commit 6719c21 into sharif-stellar-tools:master Oct 13, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Fix missing react-query dependency and configure QueryClientProvider

2 participants