Skip to content

[Bug] Fix missing react-query dependency and configure QueryClientProvider #63

Closed

Description

@SharifIbrahimDev

Background

In sharif-chain-scope/src/hooks/useTransactionHistory.ts, the hook imports and uses useQuery from react-query. However, react-query is not listed in the dependencies of package.json. Additionally, the React application has no root-level QueryClient initialized or wrapped with QueryClientProvider, which will cause runtime crashes.

Description

Add the missing dependency to package.json and properly wrap the React app layout in the query provider.

Acceptance Criteria

  • Add @tanstack/react-query to dependencies in package.json.
  • Instantiate a QueryClient at the application root (e.g., src/index.tsx or src/App.tsx).
  • Wrap the Dashboard or root component within <QueryClientProvider client={queryClient}>.
  • Verify that running npm run dev builds successfully and doesn't crash in the browser.

Activity

  1. WilliamK112 commented on Aug 1, 2026

    @WilliamK112
    Contributor

    Implemented in #86.

    The PR replaces the legacy React Query dependency, migrates the hook to the v5 API, adds the missing Vite entry point, and mounts Dashboard inside QueryClientProvider.

    Validation completed:

    • npm ci
    • npm test -- --runInBand — 79 tests passed
    • npm run build — passed
    • browser smoke test — dashboard rendered with 12 transaction rows and filter controls; zero console errors

    The current red PR Automation / pr-review check is unrelated to the patch: the repository workflow fails while trying to post its welcome comment because its GITHUB_TOKEN only has read permissions (403 Resource not accessible by integration).

  2. ranjeet150 commented on Sep 15, 2026

    @ranjeet150

    Hey maintainers,

    I would love to take this on. My planned approach:

    • Implement [Bug] Fix missing react-query dependency and configure QueryClientProvider following the existing UI design system, accessibility standards, and responsive styling.
    • Verify UI performance and zero console errors.

    Excited to work on this—please assign to me and I will submit a clean PR shortly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions