Conversation
mrobinson
changed the title
filedesciptor.rs testsfiledesciptor.rs tests
mrobinson
added a commit
that referenced
this pull request
Jan 13, 2026
… tests #747 This should fix the build on CI. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
mrobinson
added a commit
that referenced
this pull request
Jan 14, 2026
… tests #747 This should fix the build on CI. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Member
Author
sagudev
approved these changes
Jan 14, 2026
| CFRunLoop::run_current(); | ||
| assert_eq!(info.value, kCFFileDescriptorWriteCallBack); | ||
|
|
||
| info.value = 0; |
Member
There was a problem hiding this comment.
Not sure if this assignment is really unused, given that we have ptr to info info: &mut info as *mut _ as *mut c_void,, although given aliasing rules I get why compiler says so, but that's not what it was probably intended. The correct thing would be to use UnsafeCell or smth like that here.
So I think we should keep it to preserve original intention.
mrobinson
changed the title
filedesciptor.rs testsmacos-13 builder
This should fix the build on CI. Co-authored-by: @sagudev Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the build on CI. This also incorporate #744
as that is required to get the CI working again.
Signed-off-by: Martin Robinson mrobinson@igalia.com