Fix get_descriptors memory leak - #746
Merged
mrobinson merged 1 commit intoJan 15, 2026
Merged
Conversation
Contributor
Author
That would make sense. To be honest, I didn't check the file history. I just figured "bugs happen" and I should make a PR to fix it. The leak isn't the biggest deal for Zed since we cache the results, but I would still really appreciate it if this got merged. |
Anthony-Eid
added a commit
to zed-industries/zed
that referenced
this pull request
Dec 17, 2025
The below memory leaks were caused by failing to release reference counted resources. I confirmed using instruments that my changes stopped the leaks from occurring. - System prompts - Screen capturing - loading font families There were also two memory leaks I found from some of our dependencies that I made PRs to fix - RustAudio/coreaudio-rs#147 - servo/core-foundation-rs#746 Release Notes: - N/A
HactarCE
pushed a commit
to zed-industries/zed
that referenced
this pull request
Dec 17, 2025
The below memory leaks were caused by failing to release reference counted resources. I confirmed using instruments that my changes stopped the leaks from occurring. - System prompts - Screen capturing - loading font families There were also two memory leaks I found from some of our dependencies that I made PRs to fix - RustAudio/coreaudio-rs#147 - servo/core-foundation-rs#746 Release Notes: - N/A
rtfeldman
pushed a commit
to zed-industries/zed
that referenced
this pull request
Jan 5, 2026
The below memory leaks were caused by failing to release reference counted resources. I confirmed using instruments that my changes stopped the leaks from occurring. - System prompts - Screen capturing - loading font families There were also two memory leaks I found from some of our dependencies that I made PRs to fix - RustAudio/coreaudio-rs#147 - servo/core-foundation-rs#746 Release Notes: - N/A
Contributor
Author
|
@madsmtm Is there anything else I can do to get this PR merged? Or should I just wait until a reviewer has time? |
jdm
approved these changes
Jan 13, 2026
jdm
enabled auto-merge
January 13, 2026 05:59
Contributor
|
CI was fixed in #747. This might need another attempt. |
Member
|
@Anthony-Eid Can you rebase your changes and push to this branch or give maintainers access to modify this pull request? |
This function incorrectly assumed that `CTFontCollectionCreateMatchingFontDescriptors` doesn't follow the *Create* rule which is false. From Apple's docs > A retained reference to an array of normalized font descriptors matching the collection definition. https://leopard-adc.pepas.com/documentation/Carbon/Reference/CTFontCollectionRef/Reference/reference.html#//apple_ref/c/func/CTFontCollectionCreateMatchingFontDescriptors I also confirmed using instruments that this was causing a memory leak in Zed.
auto-merge was automatically disabled
January 15, 2026 20:33
Head branch was pushed to by a user without write access
Anthony-Eid
force-pushed
the
fix-get-descriptors-memory-leak
branch
from
January 15, 2026 20:33
33915cd to
6b17d00
Compare
Contributor
Author
done, please let me know if you need me to do anything else |
mrobinson
enabled auto-merge
January 15, 2026 21:37
1 task
jasonsmithio
pushed a commit
to paddleboarddev/paddleboard
that referenced
this pull request
May 31, 2026
The below memory leaks were caused by failing to release reference counted resources. I confirmed using instruments that my changes stopped the leaks from occurring. - System prompts - Screen capturing - loading font families There were also two memory leaks I found from some of our dependencies that I made PRs to fix - RustAudio/coreaudio-rs#147 - servo/core-foundation-rs#746 Release Notes: - N/A
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
The below memory leaks were caused by failing to release reference counted resources. I confirmed using instruments that my changes stopped the leaks from occurring. - System prompts - Screen capturing - loading font families There were also two memory leaks I found from some of our dependencies that I made PRs to fix - RustAudio/coreaudio-rs#147 - servo/core-foundation-rs#746 Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function incorrectly assumed that
CTFontCollectionCreateMatchingFontDescriptorsdoesn't follow the Create rule which is false.From Apple's docs
I also confirmed using instruments that this was causing a memory leak in Zed.