Skip to content

Publish core-text 21.1.0. - #738

Merged
mrobinson merged 1 commit into
mainfrom
jdm-patch-8
Jan 15, 2026
Merged

Publish core-text 21.1.0.#738
mrobinson merged 1 commit into
mainfrom
jdm-patch-8

Conversation

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
@jdm jdm changed the title Publish core-text 0.21.0. Publish core-text 21.1.0. Aug 1, 2025
@atouchet

atouchet commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

Can a new version of cocoa be published along with this to keep the core-graphics versions used in sync (#737)?

@atouchet

Copy link
Copy Markdown
Contributor

Does bumping core-graphics require a new major release for core-text as well? It wasn't noted in the PR maybe because of the workspace dependency but the core-graphics dependency will be bumped from 0.24 to 0.25 with this.

@vorporeal

Copy link
Copy Markdown
Contributor

What's the ETA on this release?

@atouchet

atouchet commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

ping @jdm @mrobinson I just wanted to double check if this is okay to be a minor bump instead of major and if there's anything blocking this from being published?

@mrobinson

Copy link
Copy Markdown
Member

I think a minor bump is okay for a dependency upgrade. In my mind major upgrades are only due to removal of API.

@mrobinson
mrobinson added this pull request to the merge queue Jan 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jan 7, 2026
@mrobinson

Copy link
Copy Markdown
Member

Looks like there's a compilation issue:

 error: value assigned to `info` is never read
   --> core-foundation/src/filedescriptor.rs:172:9
    |
172 |         info.value = 0;
    |         ^^^^^^^^^^^^^^
    |
    = help: maybe it is overwritten before being read?
    = note: `-D unused-assignments` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unused_assignments)]`

error: could not compile `core-foundation` (lib test) due to 1 previous error

@mrobinson
mrobinson added this pull request to the merge queue Jan 15, 2026
Merged via the queue into main with commit 6a8e54e Jan 15, 2026
8 checks passed
@atouchet

Copy link
Copy Markdown
Contributor

Thanks @mrobinson. Can this be published to crates.io?

@mrobinson

Copy link
Copy Markdown
Member

This is now released: https://crates.io/crates/core-text/21.1.0

@jdm

jdm commented Mar 4, 2026

Copy link
Copy Markdown
Member Author

I see now; I relied on the git history of the core-text directory to show me the relevant changes to core-text, but the core-graphics dependency is a workspace one and so bumping its version doesn't require modifying the core-text Cargo.toml. That's not great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants