Fix unwrap panic in extract_number_for_key in impl TraitAccessorPrivate for CTFontTraits on macOS Ventura. - #735
Merged
Conversation
jdm
approved these changes
Jul 12, 2025
Contributor
Author
|
Fixed the formatting issues here. If y'all don't use squash commits, let me know and I can merge the formatting changes into the base commit. Also, let me know if there's anything I should do vis-a-vis the build failures - they seem unrelated to my change here. |
Member
|
Yeah, I think those are clippy failures from newer rust versions that we need to address before we can merge anything. |
Member
|
Please go ahead and rebase to have the CI issues go away. |
vorporeal
force-pushed
the
vorporeal/fix-ventura-crash
branch
from
July 13, 2025 06:19
fef5f18 to
19374bd
Compare
Contributor
Author
|
Done. |
Contributor
Author
|
No rush at all (we are using a |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits out the final chunk of #517 to be reviewed and merged.
As discussed on that PR, in an ideal world, we'd have a test we could write to prove that this is required.
In practice, Warp has been using the logic in that PR for the past 3 years without issues. We did attempt, 6 months ago, to switch over to upstream (without the patch here) and had to revert that change due to this still being an issue for users running Ventura.
Given the above, we have confidence that: