Add CSV output mode - #105
Merged
Merged
Conversation
DanielEScherzer
left a comment
DanielEScherzer
left a comment
Contributor
There was a problem hiding this comment.
makes sense to me, one suggestion inline
if you want, I can switch the #99 implementation to replace things with comma separators rather than | separators, and then you could
- merge that first
- as part of this PR, switch the tests to using the CSV output, and show that the actual list doesn't change
| let mut file = BufWriter::new(std::fs::File::create(directory.join(format!("{version}.csv")))?); | ||
| for score in authors.scores { | ||
| let AuthorScore { rank, author, email, commits } = score; | ||
| writeln!(file, "{rank},{author},{email},{commits}")?; |
Contributor
There was a problem hiding this comment.
if the email is always going to be reported for CSV mode, then under DEBUG_EMAILS it will be output twice
Member
Author
There was a problem hiding this comment.
I think that's fine, it's just a debugging thing, it shouldn't be enabled on CI or when re-blessing the file (but good catch!).
Member
Author
|
Let's merge this to unblock tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created this to make it easier to run tests (#99).